Add golden test for Colorado claims extract SQL formatting#16
Merged
Conversation
This test exposes a bracket validation bug where jinja if/else branches containing SQL with closing parens cause the validator to see brackets from *both* mutually exclusive branches, driving depth negative. https://claude.ai/code/session_014YynqZn3ATqFB64gfvD8m9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new golden test case for SQL formatting validation of a complex dbt model that generates Colorado APCD (All Payers Claims Database) medical claims extracts.
Changes
New test file:
tests/data/unformatted/222_colorado_claims_extract.sqldisable-parsercomment due to conditional logic in the modelUpdated test registry:
tests/golden_test.rsgolden_unformatted_222_colorado_claims_extractto validate formatting of the Colorado claims extract modelImplementation Details
The test file includes a complete dbt model that:
https://claude.ai/code/session_014YynqZn3ATqFB64gfvD8m9